Make some of the Java classes proper utilities #926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #926 +/- ##
============================================
+ Coverage 85.96% 87.13% +1.17%
Complexity 104 104
============================================
Files 20 20
Lines 520 513 -7
Branches 66 66
============================================
Hits 447 447
+ Misses 50 43 -7
Partials 23 23
☔ View full report in Codecov by Sentry. |
MohamedSabthar
previously approved these changes
Oct 16, 2023
vil02
force-pushed
the
4926_make_some_java_classes_proper_utilities
branch
from
916e45e to
7c7b80b
Compare
native/src/main/java/io/ballerina/stdlib/udp/nativelistener/Listener.java
Show resolved
Hide resolved
vil02
force-pushed
the
4926_make_some_java_classes_proper_utilities
branch
from
6e421b1 to
6b36db8
Compare
|
@MohamedSabthar I rebased this branch - could you please approve the workflows again? |
vil02
force-pushed
the
4926_make_some_java_classes_proper_utilities
branch
from
6b36db8 to
b6cb3e3
Compare
|
@MohamedSabthar I made another rebase. Please approve the workflows again. |
Made the design cleaner by marking Java classes as `final` and explicitly declaring their default constructors as `private`. This change makes the code coverage reports more accurate. Closes #4926.
Co-authored-by: MohamedSabthar <[email protected]>
vil02
force-pushed
the
4926_make_some_java_classes_proper_utilities
branch
from
b6cb3e3 to
441b8da
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
MohamedSabthar
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Closes ballerina-platform/ballerina-library#4926.
Examples
Checklist