Incorporate review suggestions

ballerina-platform · Nov 20, 2024 · d4dc22d · d4dc22d
1 parent c2db62c
commit d4dc22d
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/examples/kafka-hub/docker-compose.yaml b/examples/kafka-hub/docker-compose.yaml
@@ -36,7 +36,7 @@ services:
             # Maximum number of records returned in a single call to consumer-poll
             KAFKA_CONSUMER_MAX_POLL_RECORDS: 50
             # The HTTP status codes for which the client should retry
-            RETRYABLE_STATUS_CODES: "500 502 503"
+            RETRYABLE_STATUS_CODES: "500,502,503"
         volumes:
             # Kafka client truststore file
             - ./_resources/secrets/kafka-client/kafka-client.trustStore.jks:/home/ballerina/resources/brokercerts/client-truststore.jks

diff --git a/examples/kafka-hub/hub/modules/config/configurations.bal b/examples/kafka-hub/hub/modules/config/configurations.bal
@@ -86,6 +86,6 @@ isolated function getRetryableStatusCodes(int[] configuredCodes) returns int[]|e
     if os:getEnv("RETRYABLE_STATUS_CODES") is "" {
         return configuredCodes;
     }
-    string[] statusCodes = re ` `.split(os:getEnv("RETRYABLE_STATUS_CODES"));
-    return statusCodes.'map(i => check int:fromString(i));
+    string[] statusCodes = re `,`.split(os:getEnv("RETRYABLE_STATUS_CODES"));
+    return statusCodes.'map(i => check int:fromString(i.trim()));
 }