Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark websubhub:HubClient as an isolated client #1054

Merged
merged 6 commits into from
Nov 22, 2024
Merged

Mark websubhub:HubClient as an isolated client #1054

merged 6 commits into from
Nov 22, 2024

Conversation

ayeshLK
Copy link
Member

@ayeshLK ayeshLK commented Nov 22, 2024 •
edited
Loading

Purpose

$subject

Fixes: #7400

Examples

N/A

Checklist

  • Linked to an issue
  • Updated the changelog
  • Added tests
  • Updated the spec
  • Checked native-image compatibility

@ayeshLK ayeshLK marked this pull request as draft November 22, 2024 06:19
@ayeshLK ayeshLK marked this pull request as ready for review November 22, 2024 06:30
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

RDPerera
RDPerera approved these changes Nov 22, 2024
View reviewed changes
Copy link
Member

@RDPerera RDPerera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ayeshLK ayeshLK merged commit 42001e5 into ballerina-platform:main Nov 22, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RDPerera RDPerera RDPerera approved these changes

@NipunaRanasinghe NipunaRanasinghe NipunaRanasinghe left review comments

@shafreenAnfar shafreenAnfar Awaiting requested review from shafreenAnfar shafreenAnfar is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mark websubhub:HubClient as an isolated client
3 participants
@ayeshLK @NipunaRanasinghe @RDPerera