Fix Native Data Retention Issue #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RDPerera
requested review from
indikasampath2000,
abeykoon,
RolandHewage and
SkNuwanTissera
as code owners
ayeshLK
reviewed
Sep 15, 2023
NipunaRanasinghe
previously approved these changes
Sep 18, 2023
ayeshLK
reviewed
Sep 18, 2023
native/src/main/java/org/ballerinax/asb/receiver/MessageReceiver.java
Outdated
Show resolved
Hide resolved
NipunaRanasinghe
previously approved these changes
Sep 18, 2023
RDPerera
dismissed stale reviews from NipunaRanasinghe and ayeshLK
via
925c2c3
RDPerera
force-pushed
the
memory-leak-fix
branch
from
925c2c3 to
54fdc3b
Compare
ayeshLK
reviewed
Sep 25, 2023
ayeshLK
reviewed
Sep 25, 2023
ayeshLK
reviewed
Sep 25, 2023
NipunaRanasinghe
approved these changes
Oct 5, 2023
ayeshLK
approved these changes
Oct 12, 2023
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The issue has been resolved by placing the Java-side message object as the native data within the message itself, rather than associating it with a receiver client. This way, the garbage collector will take care of cases involving data that is not handled(data that didn't go through a completion, abandonment, or movement to the dead letter queue).
Fixes Data Retention Issue
Related Pull Requests (remove if not relevant)
One line release note:
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
The new solution was tested by sending large messages over an extended period of time without handling them through the testing application. Subsequently, an analysis of memory usage and garbage collection behavior was conducted using JProfiler. As indicated in above figure, it was observed that the garbage collector successfully cleaned up the unhandled messages after period of time.