Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protect trace API token by passing it through an environment variable #6

Merged
merged 4 commits into from
Oct 10, 2023

Conversation

NipunaMadhushan
Copy link
Contributor

Purpose

Currently, users have to pass the trace api token in the reporterEndpoint configuration and it may lead to security issues. This will provide the user the capability of passing the trace API token with an environment variable named as TRACE_API_TOKEN. Therefore users do not need to pass the trace api token with trace api URL anymore.

Goals

Reduce security issues while using zipkin library.

Fixes #5

keizer619
keizer619 previously approved these changes Oct 9, 2023
@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (00f33b4) 0.00% compared to head (bf3762c) 0.00%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main      #6   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files          3       3           
  Lines         56      60    +4     
  Branches       5       6    +1     
=====================================
- Misses        56      60    +4     
Files Coverage Δ
...ina/observe/trace/zipkin/ZipkinTracerProvider.java 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@NipunaMadhushan NipunaMadhushan merged commit d08a1c4 into ballerina-platform:main Oct 10, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Protect trace API by using environment variables
2 participants