Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve client tool constant generation code #42

Merged
merged 4 commits into from
Oct 16, 2023

Conversation

rashmibharambe
Copy link
Contributor

Purpose

Fixes ballerina-platform/ballerina-library#3731

ballerina-platform/ballerina-library#3731

Examples

Checklist

  • Linked to an issue
  • Updated the changelog
  • Added tests
  • Updated the spec

@CLAassistant
Copy link

CLAassistant commented Oct 8, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@dilanSachi dilanSachi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (98f45ae) 86.50% compared to head (1116319) 86.50%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main      #42      +/-   ##
============================================
- Coverage     86.50%   86.50%   -0.01%     
+ Complexity      713      707       -6     
============================================
  Files            56       56              
  Lines          3202     3200       -2     
  Branches        355      355              
============================================
- Hits           2770     2768       -2     
  Misses          327      327              
  Partials        105      105              
Files Coverage Δ
.../syntaxtree/utils/ClientSampleSyntaxTreeUtils.java 94.00% <94.73%> (-0.06%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dilanSachi dilanSachi merged commit da5b700 into ballerina-platform:main Oct 16, 2023
4 checks passed
@rashmibharambe
Copy link
Contributor Author

@dilanSachi Could you please add hacktoberfest-accepted label to this PR so its counted on hacktoberfest dashboard. Thanks.

@dilanSachi
Copy link
Contributor

@dilanSachi Could you please add hacktoberfest-accepted label to this PR so its counted on hacktoberfest dashboard. Thanks.

Added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve client tool constant generation code
3 participants