-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add static rule for unused Function parameters #24
Add static rule for unused Function parameters #24
Conversation
…ama-pathirage-patch-1 Create CODEOWNERS file
…ama-pathirage-patch-2 Update CODEOWNERS
scan-command/src/main/java/io/ballerina/scan/internal/StaticCodeAnalyzer.java
Outdated
Show resolved
Hide resolved
scan-command/src/test/resources/test-resources/core-rules/unused_func_parameters.bal
Outdated
Show resolved
Hide resolved
scan-command/src/test/resources/test-resources/core-rules/unused_func_parameters.bal
Outdated
Show resolved
Hide resolved
scan-command/src/main/java/io/ballerina/scan/utils/Constants.java
Outdated
Show resolved
Hide resolved
scan-command/src/main/java/io/ballerina/scan/utils/ScanCodeAnalyzerUtils.java
Outdated
Show resolved
Hide resolved
scan-command/src/test/java/io/ballerina/scan/internal/StaticCodeAnalyzerTest.java
Outdated
Show resolved
Hide resolved
scan-command/src/test/resources/test-resources/core-rules/unused_func_parameters.bal
Outdated
Show resolved
Hide resolved
scan-command/src/main/java/io/ballerina/scan/internal/StaticCodeAnalyzer.java
Outdated
Show resolved
Hide resolved
scan-command/src/main/java/io/ballerina/scan/internal/StaticCodeAnalyzer.java
Outdated
Show resolved
Hide resolved
scan-command/src/main/java/io/ballerina/scan/internal/StaticCodeAnalyzer.java
Outdated
Show resolved
Hide resolved
…ina-platform/static-code-analysis-tool into unused_function_parameters
scan-command/src/main/java/io/ballerina/scan/utils/RuleDescription.java
Outdated
Show resolved
Hide resolved
scan-command/src/test/java/io/ballerina/scan/internal/CheckPanicAnalyzerTest.java
Outdated
Show resolved
Hide resolved
scan-command/src/main/java/io/ballerina/scan/internal/StaticCodeAnalyzer.java
Outdated
Show resolved
Hide resolved
scan-command/src/main/java/io/ballerina/scan/internal/StaticCodeAnalyzer.java
Outdated
Show resolved
Hide resolved
scan-command/src/main/java/io/ballerina/scan/internal/StaticCodeAnalyzer.java
Outdated
Show resolved
Hide resolved
scan-command/src/test/resources/test-resources/core-rules/unused_func_parameters.bal
Outdated
Show resolved
Hide resolved
scan-command/src/test/resources/test-resources/core-rules/unused_func_parameters.bal
Outdated
Show resolved
Hide resolved
scan-command/src/main/java/io/ballerina/scan/internal/StaticCodeAnalyzer.java
Outdated
Show resolved
Hide resolved
scan-command/src/test/resources/test-resources/core-rules/unused_func_parameters.bal
Outdated
Show resolved
Hide resolved
scan-command/src/test/resources/test-resources/core-rules/unused_func_parameters.bal
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few minor nits other than that LGTM
scan-command/src/main/java/io/ballerina/scan/internal/StaticCodeAnalyzer.java
Outdated
Show resolved
Hide resolved
scan-command/src/main/java/io/ballerina/scan/internal/StaticCodeAnalyzer.java
Outdated
Show resolved
Hide resolved
scan-command/src/main/java/io/ballerina/scan/internal/StaticCodeAnalyzer.java
Outdated
Show resolved
Hide resolved
scan-command/src/main/java/io/ballerina/scan/internal/StaticCodeAnalyzer.java
Outdated
Show resolved
Hide resolved
scan-command/src/test/java/io/ballerina/scan/internal/CheckPanicAnalyzerTest.java
Outdated
Show resolved
Hide resolved
scan-command/src/main/java/io/ballerina/scan/utils/RuleDescription.java
Outdated
Show resolved
Hide resolved
scan-command/src/main/java/io/ballerina/scan/internal/StaticCodeAnalyzer.java
Outdated
Show resolved
Hide resolved
scan-command/src/main/java/io/ballerina/scan/internal/CoreRule.java
Outdated
Show resolved
Hide resolved
scan-command/src/main/java/io/ballerina/scan/utils/RuleDescription.java
Outdated
Show resolved
Hide resolved
scan-command/src/main/java/io/ballerina/scan/utils/RuleDescription.java
Outdated
Show resolved
Hide resolved
scan-command/src/test/java/io/ballerina/scan/internal/CheckPanicAnalyzerTest.java
Outdated
Show resolved
Hide resolved
scan-command/src/test/resources/test-resources/core-rules/unused_anonymous_func_parameters.bal
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
scan-command/src/main/java/io/ballerina/scan/utils/RuleDescription.java
Outdated
Show resolved
Hide resolved
scan-command/src/main/java/io/ballerina/scan/internal/CoreRule.java
Outdated
Show resolved
Hide resolved
scan-command/src/test/java/io/ballerina/scan/internal/CheckpanicExpressionAnalyzerTest.java
Outdated
Show resolved
Hide resolved
scan-command/src/main/java/io/ballerina/scan/internal/ProjectAnalyzer.java
Outdated
Show resolved
Hide resolved
scan-command/src/test/java/io/ballerina/scan/internal/Rule001.java
Outdated
Show resolved
Hide resolved
scan-command/src/test/java/io/ballerina/scan/internal/Rule001.java
Outdated
Show resolved
Hide resolved
scan-command/src/test/java/io/ballerina/scan/internal/Rule001.java
Outdated
Show resolved
Hide resolved
scan-command/src/test/java/io/ballerina/scan/internal/Rule002.java
Outdated
Show resolved
Hide resolved
scan-command/src/test/java/io/ballerina/scan/internal/Rule002.java
Outdated
Show resolved
Hide resolved
scan-command/src/test/java/io/ballerina/scan/utils/RuleDescription.java
Outdated
Show resolved
Hide resolved
…emplate Add issue template
scan-command/src/test/java/io/ballerina/scan/internal/Rule001.java
Outdated
Show resolved
Hide resolved
…ode-analysis-tool into unused_function_parameters
Quality Gate passedIssues Measures |
8ef5511
into
ballerina-platform:static-code-analysis-tool
Please find the design document in here.
The rule description - https://docs.google.com/document/d/117SJltpBJU4lb5hzhTZQe2rTOig_5O97tqetRzHeyU8/edit#heading=h.vpboasbhujcf