Fix incorrect error diagnostic location parameters #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## static-code-analysis-tool #31 +/- ##
===============================================================
+ Coverage 88.95% 89.32% +0.37%
- Complexity 182 197 +15
===============================================================
Files 18 18
Lines 706 740 +34
Branches 77 79 +2
===============================================================
+ Hits 628 661 +33
Misses 49 49
- Partials 29 30 +1 ☔ View full report in Codecov by Sentry. |
|
MaryamZi
reviewed
Nov 1, 2024
Comment on lines
+48
to
+50
| this.location = new BLangDiagnosticLocation(lineRange.fileName(), lineRange.startLine().line() + 1, | ||
| lineRange.endLine().line() + 1, lineRange.startLine().offset() + 1, lineRange.endLine().offset() + 1, | ||
| textRange.startOffset() + 1, textRange.length()); |
There was a problem hiding this comment.
We shouldn't change this. We should change the assertion util method instead. Similar to org.ballerinalang.test.BAssertUtil#validateError(org.ballerinalang.test.CompileResult, int, java.lang.String, int, int).
gayaldassanayake
deleted the branch
ballerina-platform:static-code-analysis-tool
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #29