optimize start block #666
Open
optimize start block #666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barakman
requested changes
May 22, 2024
| @@ -1293,7 +1293,7 @@ def get_start_block( | |||
| elif mgr.tenderly_fork_id: | |||
| return safe_int(max(block["last_updated_block"] for block in mgr.pool_data)) - reorg_delay, mgr.w3_tenderly.eth.block_number | |||
| else: | |||
| return safe_int(max(block["last_updated_block"] for block in mgr.pool_data)) - reorg_delay, None | |||
| return max(safe_int(max(block["last_updated_block"] for block in mgr.pool_data)) , last_block) - reorg_delay, None | |||
There was a problem hiding this comment.
Isn't it that by definition last_block >= last_updated_block for all for blocks in mgr.pool_data?
In which case, your code is equivalent to simply returning last_block.
From looking into how this function is used, it seems that the returned value is then passed on to function get_latest_events, which means that if the value of last_block is passed to it, then most likely no events will be fetched (or perhaps only the events in the very last block).
So I suspect this this fix achieves undesired behavior (perhaps it reduces the time spent on fetching blocks, but on the same time, it may be skipping many required events).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.