Cleaning package for release #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I couldn't find any direct use of these packages in the source code. I was able to run all tox tasks locally on GCE/compute01.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #111 +/- ##
=======================================
Coverage 66.60% 66.60%
=======================================
Files 14 14
Lines 1560 1560
=======================================
Hits 1039 1039
Misses 521 521 ☔ View full report in Codecov by Sentry. |
The Jupyterbook build action failed. Found these by grep.
This was passing on GCE/compute01
Renamed these actions to reflect this aspect of the git workflow.
jared321
changed the title
Use explicit OS version names. In particular, it is now explicit that we are running on the macOS 14 runner, which is arm64 based.
That test revealed that macos-14 is ARM64 and that the package tests on that runner are pulling down the openbtmixing-1.0.1-py3-none-macosx_12_0_arm64.whl wheel. While it runs through successfully, the otool output shows that the OpenBT CLT libraries are set to the installation path on my machine at the time of creating the wheel. Not clear how the tests run through.
I injected a minor issue that should normally qualify as a warning. I want to see RTD fail due to treating it as an error.
The sphinx GH action and RTD both failed as expected due to the injected warning.
jared321
changed the title
asemposki
approved these changes
Sep 5, 2024
|
All looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minimize and clean-up external dependencies. At the same time, clean-up GH actions so that they are more conservative and run on pushes to main branches. This includes renaming to reflect that current PR-based actions are more general.
Pending work for Jared
bilby-based optional dependence specification for Taweret based on Alexandra's decisionsPending work for @asemposki
bilbyare needed in Taweret and how they should be specified (See Issue Reevaluate package external dependencies #90)