Setup PyPI publish action #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #116 +/- ##
=======================================
Coverage 66.62% 66.62%
=======================================
Files 14 14
Lines 1561 1561
=======================================
Hits 1040 1040
Misses 521 521 ☔ View full report in Codecov by Sentry. |
These are the distributions that we should eventually test & publish.
Add in stand-in job for publishing. This will have to be altered directly on main after this branch is merged into main.
I confirmed locally that builds end in error with non-zero exit code. This is to confirm that new package publishing action fails appropriately.
The previous bug did cause the GH publication action to fail during the distribution build phase as expected. The new bug should cause a failure when testing the installed distributions.
The bug injected in the last commit did not lead to GH action failures because the test command was not returning the exit code of the test() function.
The GH test actions all indicated the expected failure. This should get all actions passing again in preparation for the merge.
asemposki
approved these changes
Sep 18, 2024
Integrate main into branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basic work needed for Issue #94 is now done on this branch and is ready for merging into
mainin support of deploying the official v1.1.0 distributions to PyPI.The publishing action built up here needs to be on
mainso that the action can only be triggered by publishing an official release. Therefore, the publication portion of the action is not yet written and will be developed directly onmainafter this branch is merged tomain.I did the following to review this PR
tar tvfz <dist>and by inspecting installation in site-packages.