Add no_std support #197
Merged
Add no_std support #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move source of shadow-rs to a new folder and add it as a workspace member. This is done because joined workspace and crate tomls are not specified and they work only because of implementation details.
|
this PR would close #91 |
|
Thx @mchodzikiewicz |
|
cool! what are the plans for a release? |
|
@mchodzikiewicz I plan to release it this week and need to make some modifications. |
|
Ah, sorry, I just noticed, I partially broke git module :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings no_std support to shadow.
I tested it with my embassy project and it works like a charm.
Since now, this will require publishing two crates,
shadow-rsandshadow-rs-consumer, note thatshadow-rsdepends on consumer crate to avoid breaking existing code that usesshadow-rsin both,[build-dependencies]and[dependencies](I tested it to a limited degree).It might be worth to consider to change the docs to always recommend adding
shadow-rs-consumerto[dependencies]instead.There's one related TODO in
shadow-rs'sCargo.toml- onceshadow-rs-consumeris published, I'd recommend to change this dependency to crates.io. This introduces a little bootstrapping problem in caseshadow-rs-consumerwill change. I left this unaddressed.