Remove deprecated trigger rule (apache#43349)

bareketamir · Nov 11, 2024 · c82a76e · c82a76e
1 parent 084e29e
commit c82a76e
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 4 deletions.
diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
@@ -667,7 +667,8 @@ repos:
           ^.*RELEASE_NOTES\.rst$|
           ^contributing-docs/03_contributors_quick_start.rst$|
           ^.*\.(png|gif|jp[e]?g|tgz|lock)$|
-          git
+          git|
+          ^newsfragments/43368\.significant\.rst$
       - id: check-base-operator-partial-arguments
         name: Check BaseOperator and partial() arguments
         language: python

diff --git a/airflow/utils/trigger_rule.py b/airflow/utils/trigger_rule.py
@@ -33,7 +33,6 @@ class TriggerRule(str, Enum):
     NONE_FAILED = "none_failed"
     NONE_FAILED_OR_SKIPPED = "none_failed_or_skipped"
     NONE_SKIPPED = "none_skipped"
-    DUMMY = "dummy"
     ALWAYS = "always"
     NONE_FAILED_MIN_ONE_SUCCESS = "none_failed_min_one_success"
     ALL_SKIPPED = "all_skipped"

diff --git a/newsfragments/43368.significant.rst b/newsfragments/43368.significant.rst
@@ -0,0 +1,5 @@
+Deprecated trigger rule ``TriggerRule.DUMMY`` removed
+
+**Breaking Change**
+
+The trigger rule ``TriggerRule.DUMMY`` was removed.
diff --git a/tests/utils/test_trigger_rule.py b/tests/utils/test_trigger_rule.py
@@ -34,11 +34,10 @@ def test_valid_trigger_rules(self):
         assert TriggerRule.is_valid(TriggerRule.NONE_FAILED)
         assert TriggerRule.is_valid(TriggerRule.NONE_FAILED_OR_SKIPPED)
         assert TriggerRule.is_valid(TriggerRule.NONE_SKIPPED)
-        assert TriggerRule.is_valid(TriggerRule.DUMMY)
         assert TriggerRule.is_valid(TriggerRule.ALWAYS)
         assert TriggerRule.is_valid(TriggerRule.NONE_FAILED_MIN_ONE_SUCCESS)
         assert TriggerRule.is_valid(TriggerRule.ALL_DONE_SETUP_SUCCESS)
-        assert len(TriggerRule.all_triggers()) == 14
+        assert len(TriggerRule.all_triggers()) == 13
 
         with pytest.raises(ValueError):
             TriggerRule("NOT_EXIST_TRIGGER_RULE")