Skip to content

Commit

Permalink
rtp: remove rtcp_psfb_sli_encode() (unused)
Browse files Browse the repository at this point in the history
SLI is not used in our stack.
Also contributes to increased code coverage.
  • Loading branch information
alfredh authored and sreimers committed Dec 20, 2024
1 parent 70f1123 commit 5898c8e
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 20 deletions.
18 changes: 0 additions & 18 deletions src/rtp/fb.c
Original file line number Diff line number Diff line change
Expand Up @@ -48,24 +48,6 @@ int rtcp_rtpfb_gnack_encode(struct mbuf *mb, uint16_t pid, uint16_t blp)
}


/**
* Encode an RTCP Slice Loss Indication (SLI) message
*
* @param mb Buffer to encode into
* @param first Macroblock (MB) address of the first lost macroblock
* @param number Number of lost macroblocks
* @param picid Picture ID
*
* @return 0 for success, otherwise errorcode
*/
int rtcp_psfb_sli_encode(struct mbuf *mb, uint16_t first, uint16_t number,
uint8_t picid)
{
const uint32_t v = first<<19 | number<<6 | picid;
return mbuf_write_u32(mb, htonl(v));
}


/* Decode functions */


Expand Down
2 changes: 0 additions & 2 deletions src/rtp/rtcp.h
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,6 @@ int rtcp_make_sdes_cname(const struct rtp_sock *rs, struct mbuf *mb);

/* RTCP Feedback */
int rtcp_rtpfb_gnack_encode(struct mbuf *mb, uint16_t pid, uint16_t blp);
int rtcp_psfb_sli_encode(struct mbuf *mb, uint16_t first, uint16_t number,
uint8_t picid);
int rtcp_rtpfb_twcc_decode(struct mbuf *mb, struct twcc *msg, int n);
int rtcp_rtpfb_decode(struct mbuf *mb, struct rtcp_msg *msg);
int rtcp_psfb_decode(struct mbuf *mb, struct rtcp_msg *msg);
Expand Down

0 comments on commit 5898c8e

Please sign in to comment.