Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmake/config: set HAVE_THREADS only if threads.h #1005

Merged
merged 4 commits into from
Nov 16, 2023
Merged

cmake/config: set HAVE_THREADS only if threads.h #1005

merged 4 commits into from
Nov 16, 2023

Conversation

sreimers
Copy link
Member

@sreimers sreimers commented Nov 16, 2023 •
edited
Loading

Fixes #1004

@sreimers sreimers marked this pull request as ready for review November 16, 2023 08:45
@sreimers sreimers mentioned this pull request Nov 16, 2023
Closed
@sreimers sreimers merged commit ebdf9d7 into main Nov 16, 2023
43 checks passed
@sreimers sreimers deleted the cmake_visual_studio_threads branch November 16, 2023 08:48
@BillyONeal
Copy link

As an aside, it might be a good idea to use your win32 implementation there since C threads there are a wrapper around the native APIs and you've already done that work :).

I'll update vcpkg's copy of baresip-libre to 3.6.2 and add this patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

HAVE_THREADS and Visual Studio 2022, version 17.8
2 participants
@sreimers @BillyONeal