Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: move test_rtcp_decode_badmsg() to separate testcase #1041

Merged
merged 2 commits into from
Jan 5, 2024

Conversation

alfredh
Copy link
Contributor

@alfredh alfredh commented Jan 4, 2024

cppcheck:

test/rtp.c:424:9: warning: Identical condition and return expression 'err', return value is always 0 [identicalConditionAfterEarlyExit]
 return err;
        ^
test/rtp.c:417:6: note: If condition 'err' is true, the function will return/exit
 if (err)
     ^
test/rtp.c:424:9: note: Returning identical expression 'err'
 return err;
        ^

@alfredh
Copy link
Contributor Author

alfredh commented Jan 5, 2024

the PR is complete and retest is also happy..

please review and merge ..

@sreimers sreimers merged commit 34cce57 into main Jan 5, 2024
44 checks passed
@sreimers sreimers deleted the test_rtcp_decode_badmsg branch January 5, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants