audio: cleanup start/stop redundancy part 1 #1073
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cspiel1
changed the title
|
@sreimers please could you have a look? |
Looks like a local problem (beep.wav from test data path is not found). The CI error here is:
|
sreimers
reviewed
Mar 5, 2024
| @@ -764,6 +764,9 @@ const struct sdp_format *sdp_media_rformat(const struct sdp_media *m, | |||
| if (!fmt->sup) | |||
| continue; | |||
|
|
|||
| if (!fmt->data) | |||
There was a problem hiding this comment.
Not sure about this, struct sdp_format->ench and data are both optional and related to codec.
There was a problem hiding this comment.
ah, okay. I have to look closer.
|
Doesn't make sense to change this due to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helps to remove redundancy in baresip: baresip/baresip#2943