sipreg/reg.c: stop retrying registers early after 401/407 #1143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maximilianfridrich
force-pushed
the
registration_early_fail
branch
from
202c1d3 to
c2a090d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, REGISTERs are retried until the loop detection mechanism kicks in, which results in 16 unsuccessful REGISTERs being sent in very quick succession if the REGISTER can't be authorized (401 or 407 responses).
Now, on 401 and 407 responses, the REGISTER is only retried once (instead of 16 times). Re-trying the same request 16 times with the same auth credentials doesn't make much sense.