add filter_registrar option #1160
Conversation
maximilianfridrich
force-pushed
the
transp_no_listen
branch
from
68b0bd1 to
918b22c
Compare
src/sip/transp.c
Outdated
| &transp->laddr, | ||
| sip_transp_name(transp->tp)); | ||
| sip_transp_name(transp->tp), | ||
| sa_port(&transp->laddr) ? "" : "not "); |
There was a problem hiding this comment.
Should we use positive logic?
- print "(listening)" only if listening is enabled
- print nothing if it is not enabled
There was a problem hiding this comment.
Maybe this function should be adapted in general. Currently, if no listening socket is open for a transport, this function will print e.g.
172.21.0.1:0 (TCP) (not listening)
Not sure if that makes sense since there is no socket option. Maybe we should print something like:
transports:
UDP, TCP
transport sockets:
172.21.0.1:5060 (TCP)
and only list actually open sockets
There was a problem hiding this comment.
I have updated it. Now only listening sockets are listed and at the beginning the enabled transport protocols are listed. E.g.:
transports:
UDP
TCP
transport sockets:
10.0.0.5:5060 (TCP) (listening)
10.0.0.5:46080 (UDP) (listening)
connections:
connection configurations:
client transactions:
REGISTER COMPLETED 3s (z9hG4bK4053721133a7884a)
REGISTER COMPLETED 3s (z9hG4bK4914acbc12294034)
There was a problem hiding this comment.
Why then print "(listening)" on each line?
There was a problem hiding this comment.
Done. Removed the "(listening)".
maximilianfridrich
force-pushed
the
transp_no_listen
branch
3 times, most recently
from
001c714 to
ecef413
Compare
src/sip/transp.c
Outdated
| if (!transp->sock) { | ||
| err = udp_listen((struct udp_sock **) | ||
| &transp->sock, &transp->laddr, | ||
| udp_recv_handler, transp); |
There was a problem hiding this comment.
Can we avoid to open the UDP listen socket if listen=false?
There was a problem hiding this comment.
Like discussed: Please remove the changes 1518-1534. For UDP it makes no difference if the listen socket is opened at startup or at first REGISTER.
There was a problem hiding this comment.
Yes, with UDP a listening socket has to be opened regardless, so there's not really a point in not opening the socket when adding the transport. Done.
maximilianfridrich
force-pushed
the
transp_no_listen
branch
from
ecef413 to
91b6b57
Compare
to add SIP transport protocol without opening a listening socket and adapt sip_transp_send accordingly to make UDP work.
maximilianfridrich
force-pushed
the
transp_no_listen
branch
from
91b6b57 to
6579acf
Compare
transp.c: add sip_transp_add_sock
to add SIP transport protocol without opening a listening socket (UDP socket is always opened).
Related: