Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: call - add call on-hold/resume test #990

Merged
merged 3 commits into from
Oct 26, 2023

Conversation

cspiel1
Copy link
Collaborator

@cspiel1 cspiel1 commented Oct 23, 2023

can be used for unit tests

@cspiel1 cspiel1 changed the title sess: add sipsess_ack_pending() test: call - add call on-hold/resume test Oct 23, 2023
@cspiel1 cspiel1 marked this pull request as draft October 23, 2023 10:36
@cspiel1 cspiel1 force-pushed the sipsess_ack_pending branch from 02034d2 to 770a3ab Compare October 23, 2023 10:36
@cspiel1
Copy link
Collaborator Author

cspiel1 commented Oct 23, 2023

Now I reverted (temporarily) the revert of @juha-h in order to reproduce the missing ACK. On my local dev host I was not able to reproduce this with this unit test baresip/baresip#2775 that now also checks if the ACK was received.

Put this to draft. We have to clarify with @juha-h how we can reproduce the issue baresip/baresip#2772 first.

Edit: Now I have a test that fails. But the re loop is canceled to early. baresip/baresip#2775 (comment)

@cspiel1
Copy link
Collaborator Author

cspiel1 commented Oct 25, 2023

This PR and the related baresip/baresip#2775 is not able to reproduce the issue baresip/baresip#2772. The issue appears in combination with an outbound SIP proxy.

I removed the commit fc588b9 from this PR.

The reason for this PR is to add a function for checking if there is an ACK missing. This can be used in baresip/baresip#2775 for a baresip selftest in order to test call on-hold and resume and check also a final ACK for a re-INVITE.

@cspiel1 cspiel1 marked this pull request as ready for review October 25, 2023 05:47
@alfredh
Copy link
Contributor

alfredh commented Oct 25, 2023

Thanks for this patch. Looks good to me.

Should we merge it ?

@alfredh alfredh merged commit aa13ac7 into baresip:main Oct 26, 2023
34 checks passed
@cspiel1 cspiel1 deleted the sipsess_ack_pending branch October 26, 2023 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants