async: fix re_async_cancel mqueue handling #995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we can't clear/revert a mqueue_push, free list handling has always be done by async queueh and not within re_async_cancel.
cspiel1
reviewed
Oct 31, 2023
| @@ -351,7 +351,8 @@ void re_async_cancel(struct re_async *async, intptr_t id) | |||
| w->workh = NULL; | |||
| w->cb = NULL; | |||
| w->arg = mem_deref(w->arg); | |||
| list_move(&w->le, &async->freel); | |||
| /* No move to free list since queueh must always handled if | |||
| * mqueue_push is called */ | |||
There was a problem hiding this comment.
I can't see why this change has something to do if the pipe is read or not.
There was a problem hiding this comment.
Pipe queueh is always executed (since it's FIFO), so the free list move must be done there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we can't clear/revert a mqueue_push, free list handling has always be done by async
queuehand not withinre_async_cancel. Otherwise job is reused and maybe executed twice or early.fixes #992