This repository has been archived by the owner on Feb 16, 2023. It is now read-only.
aubuf: preallocate mbuf frames to avoid malloc #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alfredh
reviewed
Nov 19, 2022
| @@ -42,7 +40,14 @@ static inline int aubuf_write(struct aubuf *ab, const uint8_t *p, size_t sz) | |||
|
|
|||
| static inline int aubuf_append(struct aubuf *ab, struct mbuf *mb) | |||
There was a problem hiding this comment.
this API should probably be removed.
it contains no Samplerate or Channels info, which is needed now
alfredh
reviewed
Nov 19, 2022
| /* Values for startup preallocation, can be tuned if needed */ | ||
| enum { | ||
| SRATE = 48000, /* Default sample rate in [Hz] */ | ||
| CHANNELS = 2, /* Default number of channels */ |
There was a problem hiding this comment.
is it possible to avoid hardcoded samplerate values inside the library ?
alfredh
reviewed
Nov 19, 2022
| struct frame *f = frame_alloc(ab, SAMPSZ); | ||
| if (!f) | ||
| return ENOMEM; | ||
| } |
There was a problem hiding this comment.
instead of pre-allocating, is it possible to reuse the buffer instead ?
|
I'd like to vote again for this improvement (maybe simplified somehow). After planned v2.11.0? |
|
Yes, will take a look into this for next release. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
malloc and free calls should be avoided in realtime audio context as much as possible. this makes aubuf write/read calls ~1.8x times faster.