Add option to select a different theme on Makefile #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barraq
requested changes
Feb 11, 2017
| @@ -26,7 +26,7 @@ | |||
| $endfor$ | |||
| </head> | |||
| <body> | |||
| <header itemscope itemtype="http://http://schema.org/Person" class="$if(photo)$with-photo$endif$"> | |||
There was a problem hiding this comment.
Yes, that is why I removed and put in a separate commit as you suggested.
| @@ -48,7 +48,7 @@ <h2 class="title">$title$</h2> | |||
| <li><a class='phone' href="phoneto:$phone$">$phone$</a></li> | |||
| $endif$ | |||
| $else$ | |||
| <li><a class='phone' href="phoneto:$phone$">$phone$</a></li> | |||
There was a problem hiding this comment.
would be great in a separate commit
| @@ -12,7 +12,7 @@ mobile: '+1 (234) 567 890' | |||
| phone: '+2 (345) 678 901' | |||
| fax: '+3 (456) 789 012' | |||
| address: | |||
| city: City | |||
There was a problem hiding this comment.
all the typos fix should be put in a separate commit
|
Thanks @jfelipefilho for this contrib. I just commented the PR. |
fsantiag
force-pushed
the
support_different_themes
branch
from
37e6023 to
ae9ba64
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now it is possible to use the parameter THEME to select
a different theme. The new themes should be placed in
stylesheets/theme_name.