[nyarlathotep] Project accounts across time #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The net income calculation on the finance dashboard was broken by the omission of GBP `assets:pension` balances. Rather than make the dashboard fill in the blanks, I decided to propagate accounts for credits / debits through all times. This means the finance metrics are now defined for all (account, currency) pairs for all of time, so long as a posting for that currency ever existed, with a default value of 0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The net income calculation on the finance dashboard was broken by the omission of GBP
assets:pensionbalances. Rather than make the dashboard fill in the blanks, I decided to propagate accounts for credits / debits through all times. This means the finance metrics are now defined for all (account, currency) pairs for all of time, so long as a posting for that currency ever existed, with a default value of 0.