Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Revert "Replaced base_path('public') with public_path() in ServicePro…
- Loading branch information
de83130
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Barry, does this fix the issue with loading the orientation from the config? In that case it might be worth to implement the tests I added in #882 so this behaviour is locked in?
de83130
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jaap it don't fix that issue, he is just ignoring you
de83130
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@barryvdh This breaks if the public folder is not named
public
. In our case the public folder is namedhtdocs
and the code breaks without changes.Using
$path = realpath(app('path.public'));
would use the actual public folder as determined in the Laravel App object.de83130
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@feeela make a PR, maybe this idea: #867 (comment)
Try this: #890