Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow extensions to provide navigation links #2309

Merged
merged 1 commit into from
Feb 18, 2025
Merged

Allow extensions to provide navigation links #2309

merged 1 commit into from
Feb 18, 2025

Conversation

bartfeenstra
Copy link
Owner

@bartfeenstra bartfeenstra commented Feb 11, 2025 •
edited
Loading

This fixes #2286

@bartfeenstra bartfeenstra added enhancement New feature or request python Pull requests that update Python code documentation templating Jinja2 templating labels Feb 11, 2025
@bartfeenstra bartfeenstra force-pushed the navigation-link-provider branch 2 times, most recently from 4615dbb to a68fb4e Compare February 11, 2025 14:48
@codecov Codecov
Copy link

codecov bot commented Feb 11, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 98.87640% with 1 line in your changes missing coverage. Please review.

Project coverage is 97.88%. Comparing base (3aca181) to head (46a9173).
Report is 1 commits behind head on 0.4.x.

Files with missing lines Patch % Lines
betty/ancestry/link.py 95.83% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##            0.4.x    #2309   +/-   ##
=======================================
  Coverage   97.88%   97.88%           
=======================================
  Files         369      370    +1     
  Lines       23757    23826   +69     
  Branches     1110     1110           
=======================================
+ Hits        23254    23322   +68     
- Misses        344      345    +1     
  Partials      159      159

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bartfeenstra bartfeenstra force-pushed the navigation-link-provider branch from a68fb4e to 4a064f8 Compare February 16, 2025 11:41
bartfeenstra
bartfeenstra commented Feb 16, 2025
View reviewed changes
@bartfeenstra bartfeenstra force-pushed the navigation-link-provider branch 2 times, most recently from 2f55628 to 40b0bea Compare February 18, 2025 16:45
@bartfeenstra bartfeenstra force-pushed the navigation-link-provider branch from 40b0bea to 46a9173 Compare February 18, 2025 17:10
@bartfeenstra bartfeenstra marked this pull request as ready for review February 18, 2025 17:10
@bartfeenstra bartfeenstra merged commit e32286b into 0.4.x Feb 18, 2025
6 checks passed
@bartfeenstra bartfeenstra deleted the navigation-link-provider branch February 18, 2025 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation enhancement New feature or request python Pull requests that update Python code templating Jinja2 templating
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow extensions to provide navigation links
1 participant
@bartfeenstra