Replacing to loop and adding focus #394
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Although the previous solution worked, surrounding with while for readability. 2. Focus ( if that's the name ) : - First, reading the exsiting size value from the .toml - Then, on load, the focus will be on the configured font size, rather than on the first item. Changing font size will keep the focus on the new value. * Inside the while, in the first run, the sed will rewrite the existing value; the other approach is to move this line below the choise selection, but then, there's a need to first check that in case of "<<Back" the value won't accidently change the size = << Back in the .toml. To avoid it, I just moved the sed line above the choice and know that in the first run it will override the same value in the .toml; still looks cleaner than adding an if or a case loop.
1. Getting all apps from $OMAKUB_PATH/uninstall, removing path and app- prefix if exists, also, removing the .sh postfix, sorting and adding the "<< Back" option at the end. 2. Add header "Uninstall application" ( similar to the one in install.sh ), set height to 29 ( to see all items ). 3. Going back to $OMAKUB_PATH/uninstall to fetch the full path to the .sh app. 4. reusing the exisintg gum confirm logic. * if user is pressing Back or ctrl+c, it will bring him to previous menu.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid it, I just moved the sed line above the choice and know that in the first run it will override the same value in the .toml; still looks cleaner than adding an if or a case loop.
Also - kept the same regex; as changing it to something like loop while it's not "<< Back" breaks the ctrl+c , which by default goes to the previous menu. It's possible to add another check for this as well, but it's getting more complex than the existing regex.