TQLG-392: preselected-shipping-cost #107
Open
+31
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulapopDD
requested review from
aheartforspinach,
m-borgmann,
mloeffle and
jkniest
as code owners
| @@ -1,4 +1,5 @@ | |||
| <script setup lang="ts"> | |||
|
|
|||
There was a problem hiding this comment.
Suggested change
i think we can delete this line, or? but not that important for me haha
aheartforspinach
approved these changes
Jan 29, 2025
m-borgmann
reviewed
Feb 3, 2025
| @@ -0,0 +1,27 @@ | |||
| import type { Schemas } from '@shopware/api-client/api-types'; | |||
| import { useCart, useCheckout } from "#build/imports"; | |||
There was a problem hiding this comment.
Suggested change
| import { useCart, useCheckout } from "#build/imports"; |
I dont think we need these imports, since we are not in the module
m-borgmann
reviewed
Feb 3, 2025
Comment on lines
10
to
+11
| ); | ||
| const { preselectShippingMethod } = useShippingMethod(); |
There was a problem hiding this comment.
Suggested change
| ); | |
| const { preselectShippingMethod } = useShippingMethod(); | |
| ); | |
| const { preselectShippingMethod } = useShippingMethod(); |
m-borgmann
reviewed
Feb 3, 2025
| import { useCart, useCheckout } from "#build/imports"; | ||
|
|
||
| export function useShippingMethod() { | ||
|
|
m-borgmann
reviewed
Feb 3, 2025
|
|
||
| export function useShippingMethod() { | ||
|
|
||
| const preselectShippingMethod = async () => { |
There was a problem hiding this comment.
I think it makes sense to rename this function to "preselectShippingMethodFallback", since it serves as the fallback in case the usual preselected one is not available (and doesnt include the actual logic for the preselection in the non fallback case)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preselect the cheapest shipping method available if the one set initially on the cart( from previous orders for eg.) is not available anymore.