Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to VariableSizeList #27

Closed
wants to merge 1 commit into from
Closed

Switch to VariableSizeList #27

wants to merge 1 commit into from

Conversation

drewbrend
Copy link

@drewbrend drewbrend commented Apr 26, 2021 •
edited
Loading

See issue: #26

This PR proposes support for variable sizes of menu items/options.

I'm open to ideas on other ways to implement this or changes to the public API. This is a breaking change to the API so that should be considered. API changes:

  • itemSize renamed to getItemSize and is now a function
  • fixedSizeListRef renamed to variableSizeListRef

Screen Shot 2021-04-26 at 3 10 28 PM

@drewbrend
Copy link
Author

Closing in favour of #28

@drewbrend drewbrend closed this Apr 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@drewbrend