InstallationsService::installPlugin() のユニットテスト #3928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HungDV2022
commented
Oct 18, 2024
| */ | ||
| public function installPlugin($name) | ||
| { | ||
| BcUtil::clearAllCache(); | ||
| /* @var BcPlugin $plugin */ | ||
| $plugin = Plugin::isLoaded($name); | ||
| if(!$plugin) $plugin = Plugin::getCollection()->create($name); | ||
| if ($plugin) |
There was a problem hiding this comment.
@ryuring こちらはBoolean形で返しましたのでここでreturnをしないと次の393行目にバグを発生します。
レビューをお願いします。
There was a problem hiding this comment.
- プラグインがロードされているかどうかと、インストールされているかどうかは別問題です。
- ロードされていないとインストールできません。
- ロードされていない場合に
Plugin::getCollection()->creat()でロードしてます。 - return してしまうとインストールできません。
つまり、処理は間違っていないです。その前提でテストを書いてください。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.