Skip to content

fix(snippets): escape literal $ #1258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 13, 2025
Merged

fix(snippets): escape literal $ #1258

merged 3 commits into from
Apr 13, 2025

Conversation

dezza
Copy link
Contributor

@dezza dezza commented Feb 26, 2025

Continuation and more complete version of #1181

Adds literal $ escaping for the rest of the snippets. Without the literal escaping parsing code for placeholders is significantly more complex (magic 🧙) and incompatible with various lsp clients with snippet functionality for vim and other editors.

Continuation and more complete version of bash-lsp#1181
Copy link

codecov bot commented Mar 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.91%. Comparing base (c4cccaf) to head (1fce98a).
Report is 11 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1258   +/-   ##
=======================================
  Coverage   80.91%   80.91%           
=======================================
  Files          29       29           
  Lines        1441     1441           
  Branches      344      344           
=======================================
  Hits         1166     1166           
  Misses        221      221           
  Partials       54       54           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@skovhus skovhus merged commit 07e729e into bash-lsp:main Apr 13, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants