feat(repository): upgrade hydrateMany so that it batches queries per … #44
Conversation
|
@bashleigh , I finally got around to taking a crack at this PR nearly 2yrs on. With that said, I consider it very much a WIP, in so far as, it's working for my use-case and all the tests are passing. However, I think it needs some scrutiny as I was just playing fast and loose with the code. Not sure it's super elegant either... but hey, it does work for me :D. The biggest scenario that I don't think is covered is when you're querying up from child to parent. It doesn't look like there's a test in the spec files for that and I don't do that in my app. If you look at it and think it's a workable shot at it I can add a test for it. |
|
@bashleigh friendly ping. |
|
Sorry, I did see it, I've not been with it for a while. I need to take some time to remember what the hell was gonig through my head when I wrote all this and get myself back up to speed with all the craziness within the repo 😅 Hopefully I'll find some time next week. In fact, I'll put it in my calendar 👍🏼 |
|
@jspizziri don't suppose you can resolve the conflicts? If not I'll see if I can sort them. I've had a look but again I'm so unfamiliar with this repository now. I've found one part I wanted to add a code change suggestion to but it's a bit too much to do in github comment block so will look at doing it in VSC and see what I can do |
|
@bashleigh working on resolving these. also doing some refactoring based on the new changes. might be a while before I have things ready for review again. stay tuned. |
…entityType
#9