2.0 #217
2.0 #217
Conversation
the PB translation generates a single token instead of a default record when the entire message has only default values. This was uncovered in 1.4.4, where the cs buckets query was broken.
Fix unhandled case of empty cs buckets response
Backport of 5aa1ab0 As described in basho#156, there are several types of timeouts in the client. The timeout that is generally provided as the last argument to client operations is used to create timers which prevent us from waiting for every on messages for TCP data (from gen_tcp). There are several cases where this timeout was hardcoded to infinity. This can cause the client to hang on these requests for a (mostly) unbounded time. Even when using a gen_server timeout, the gen_server itself will continue to wait for the message to come, with no timeout. Further, because of basho#155, we simply use the `ServerTimeout` as the `RequestTimeout`, if there is not a separate `RequestTimeout`. It's possible that the `RequestTimeout` can fire before the `ServerTimeout` (this timeout is remote), but we'd otherwise just be picking some random number to be the difference between them. Addressing basho#155 will shed more light on this.
Never use infinity request timeouts
Enable compilation on OTP 18
It seems to be a breaking change not compiling on R15 properly. Will need to come up with a better solution.
Restore for now because it breaks on R15 and 16
|
Hi, Thank you for taking the time to contribute to this project. This PR represents too many changes to accept in one pull request. Would it be possible to break this up into smaller changes, each with its own set of tests to go with it? Also, the changes should be against |
|
Hi Luke, On Wed, Nov 11, 2015 at 5:15 PM, Luke Bakken [email protected]
|
|
Hi Luke, I just made 2 pull requests for the erlang client: 251 adds a new timeout mechanism, it's fully backward compatible with the 252 is built on top of 251 and adds some statistics functionality which has Let me know if you need anything else from me in relation to these changes. //Sean. On Wed, Nov 11, 2015 at 5:15 PM, Luke Bakken [email protected]
|
Added new timeout mechanism and some new stats collection.
Intended to be fully backward compatible.
See overload_test & stats_demo test functions.