Fixes #2
Open
Fixes #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed character encoding error. The Romanian Ș ș characters got garbled.
Fixed build issues where the jlatex.api module was not added to the parent pom and where Maven command line didn't like the UTF-8 encoded Romanian characters.
Addressed a couple of SonarLint warnings
Added SCM information to the pom.xml file for automatic deployment to GitHub Maven repo.
Further corrected the pom.xml file., adding the mvn repo elements to the URL.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made a few fixes and have updated the pom.xml file to support direct deployment the GitHub maven repo. I would like to create a 0.3 release so we have a full version that people can use. If you accept this pull request, I will perform a proper maven release on the main branch.