Fix missing light entities in options list #350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Easy to reproduce by renaming a light entity that is already configured as part of an adaptive lighting config, then trying to modify that adaptive lighting configuration. |
|
Ideally, another validation could be added, comparing the list of selected lights, to the current HA list of light entities, and warn the user if they have selected any lights that are not available. |
This was referenced Oct 28, 2022
Closed
|
This is awesome! Thank you so much 😄 |
|
Oops, I accidentally clicked on close instead of merge. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the GUI to set options, if a light entity, which was previously configured, is no longer available, then it won't show up in the dropdown list, and causes the validation to fail.
Validation fails with this error:
This failure means there is no way to de-select the light entity, or change any options under this condition.
This PR compares the list of configured lights, to the all_lights variable, and if any are missing, appends them to all_lights. This allows the user to de-select the light, and make changes to the options.
Will resolve the following issues:
#349
#287
#278