fix(basti): Cleanup - Prevent attempting to remove a security group from a cluster db instance

[lukeinage]

Proposed Changes

This PR fixes the issue of attempting to remove a db instance security group that is part of a cluster in basti cleanup.

security-group-cleaner.ts removes the security group from the cluster and then tries to remove it from the instance causing a 400 error.

"InvalidParameterCombination: The specified DB Instance is a member of a cluster. Modify vpc security group for the DB Cluster using the ModifyDbCluster API"

This PR checks that the db instance doesn't have a cluster identifier before attempting to remove the security group.

Checklist

• I cleaned up my code.
• All the tests and checks passed (npm run test).
• I have added necessary documentation and/or updated existing documentation.
• I have added or modified tests to cover the changes.

[BohdanPetryshyn]

Looks good to me, thank you for the contribution @lukeinage ❤️

Could you please also describe your RDS configuration that results in this error?

[lukeinage]

Sure! I can reproduce it with a default rds cluster configuration. I've created one with within cdk here

const vpc = new ec2.Vpc(this, 'Vpc');

new rds.DatabaseCluster(this, 'RdsCluster', {
    vpc,
    engine: rds.DatabaseClusterEngine.auroraPostgres({ version: rds.AuroraPostgresEngineVersion.VER_15_3 }),
    defaultDatabaseName: 'testdb',
    writer: rds.ClusterInstance.serverlessV2('WriterInstance'),
    readers: [
        rds.ClusterInstance.serverlessV2('ReaderInstance1')
    ],
    serverlessV2MinCapacity: 0.5,
    serverlessV2MaxCapacity: 1
});

I then run

basti init

and confirm all is as expected. Then I try to run

basti clean

It will clean up some resources but not all, this is the second attempt at running basti cleanup...

ℹ️ The following resources are going to be deleted:
Access security groups
  • sg-xxxxx
Bastion security groups
  • sg-xxxxx
? Proceed to cleanup? Yes
✖ Failed to prepare to access security group deletion
✖ Failed to delete bastion security group: sg-xxxxx

❌ Cleanup errors:

Unexpected error: The specified DB Instance is a member of a cluster. 
Modify vpc security group for the DB Cluster using the ModifyDbCluster API. 
The specified DB Instance is a member of a cluster. 
Modify vpc security group for the DB Cluster using the ModifyDbCluster API

Running with the PR, the cleanup runs as expected