Update Transfer Model

[gkmk]

Update Transfer model to support dynamic loading of overwritten Wallet or Transaction model classes.

Defaults to current Wallet and Transaction model from inside the package if no overwritten models specified.

[rez1dent3]

Regarding the configuration, I don't mind, you're right. But there is no need to return morphTo. To_type & from_type will be removed in version 11.x.

[rez1dent3]

@gkmk Also, I ask you to write a unit test for this code, if it’s not difficult for you.

[rez1dent3]

@gkmk I looked at your code carefully and realized that this code is not necessary.
I added the following a long time ago and in the connections you should get the correct model.

        $this->app->bind(Transaction::class, $configure['transaction']['model'] ?? null);
        $this->app->bind(Transfer::class, $configure['transfer']['model'] ?? null);
        $this->app->bind(Wallet::class, $configure['wallet']['model'] ?? null);

See: #859

[gkmk]

@rez1dent3 i see. I think we should check the migrations then because i switched to morph to relationship just because of the database structure.
About the belongs to relationships i find the definition on the model better just because it is not as magical as container binding and the responsibility is kept in one place. I also noticed that this is the pattern you have used inside other models. So it just keeps consistency.

[rez1dent3]

@gkmk okay. revert the changes with morphTo and I will merge.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fff328f) 100.00% compared to head (c4cad87) 100.00%.
Report is 2 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff             @@
##              master      #858   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity       552       552           
===========================================
  Files             83        83           
  Lines           1949      1949           
===========================================
  Hits            1949      1949           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.