Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove use_cpp_toolchain #330

Merged
merged 2 commits into from
Mar 4, 2025
Merged

refactor: remove use_cpp_toolchain #330

merged 2 commits into from
Mar 4, 2025

Conversation

udaya2899
Copy link
Contributor

@udaya2899 udaya2899 commented Mar 3, 2025 •
edited
Loading

This PR tries to use use_cpp_toolchain from @bazel_tools instead of the copied definition earlier.

@cloudhan
Copy link
Collaborator

cloudhan commented Mar 3, 2025

use_cpp_toolchain is included as separate impl is due to some very old bazel releases do not have a impl with them...
If you believe it is not the case anymore, please separate it into another PR to see what happen in the CI.

@udaya2899 udaya2899 force-pushed the udaya2899/rbe-cuda-clang branch from 173aa8f to 6a297b5 Compare March 3, 2025 18:33
@udaya2899
Copy link
Contributor Author

use_cpp_toolchain is included as separate impl is due to some very old bazel releases do not have a impl with them...
If you believe it is not the case anymore, please separate it into another PR to see what happen in the CI.

Kind of messed up my branches.. sigh. Reusing this branch to be the one that removes use_cpp_toolchain

@udaya2899 udaya2899 changed the title feat: automatically detect compiler_executable from registered cc_toolchain refactor: remove use_cpp_toolchain Mar 3, 2025
@udaya2899
Copy link
Contributor Author

CI is green! Yay. So all the versions that we support now seems to have this.

@udaya2899 udaya2899 requested a review from cloudhan March 3, 2025 18:45
@udaya2899 udaya2899 mentioned this pull request Mar 3, 2025
Open
cloudhan
cloudhan approved these changes Mar 4, 2025
View reviewed changes
Copy link
Collaborator

@cloudhan cloudhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution.

@cloudhan cloudhan merged commit 8df66c9 into bazel-contrib:main Mar 4, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cloudhan cloudhan cloudhan approved these changes

@jsharpe jsharpe Awaiting requested review from jsharpe jsharpe is a code owner

@ryanleary ryanleary Awaiting requested review from ryanleary ryanleary is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@udaya2899 @cloudhan