Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[email protected] #3735

Merged
merged 3 commits into from
Feb 7, 2025
Merged

[email protected] #3735

merged 3 commits into from
Feb 7, 2025

Conversation

ferstlf
Copy link
Contributor

@ferstlf ferstlf commented Feb 6, 2025

Note: MODULE.bazel was added to cel-spec in v0.18.0 and does not need to be patched in anymore (compared to the currently latest version v0.15.0 in BCR).

@bazel-io
Copy link
Member

bazel-io commented Feb 6, 2025

Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (cel-spec) have been updated in this PR.
Please review the changes. You can view a diff against the previous version in the "Generate module diff" check.

@ferstlf
Copy link
Contributor Author

ferstlf commented Feb 6, 2025

@bazel-io skip_check unstable_url

@bazel-io bazel-io added the skip-url-stability-check Skip the URL stability check for the PR label Feb 6, 2025
@meteorcloudy meteorcloudy added the presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval label Feb 6, 2025
@ferstlf ferstlf marked this pull request as ready for review February 6, 2025 16:28
@Wyverald
Copy link
Member

Wyverald commented Feb 6, 2025

Do note that the previous version (0.15.0) declared a compatibility level of 1, and this PR (0.19.2) does not declare it, meaning that it defaults to 0. This could cause an error if both 0.15.0 and 0.19.2 exist in the dep graph. I'm assuming that's not intentional?

@ferstlf
Copy link
Contributor Author

ferstlf commented Feb 7, 2025

Do note that the previous version (0.15.0) declared a compatibility level of 1, and this PR (0.19.2) does not declare it, meaning that it defaults to 0. This could cause an error if both 0.15.0 and 0.19.2 exist in the dep graph. I'm assuming that's not intentional?

No that was not intentional, thanks. I added the compatibility level.

@meteorcloudy
Copy link
Member

Yeah, we should have an automatic compatibility level change warning..

@meteorcloudy meteorcloudy enabled auto-merge (squash) February 7, 2025 10:32
@meteorcloudy meteorcloudy merged commit 2383342 into bazelbuild:main Feb 7, 2025
20 checks passed
@mattnworb mattnworb mentioned this pull request Feb 27, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval skip-url-stability-check Skip the URL stability check for the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants