[8.0.0] Allow any attributes on non-registry overrides #24443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PiperOrigin-RevId: 696230400 Change-Id: I3a190dedf4ea35c012383d757db46351505b71af
PiperOrigin-RevId: 696985671 Change-Id: I2bd694ed13abb99e018ce35c2455e002e6fcb3c3
So this kind of ran away from me... * The motivator for this PR was to allow any `http_archive` attributes to be specified on `archive_override`. It was kind of a design oversight that we didn't allow this, to be honest; we've slowly accumulated fixes like adding `init_gitsubmodules` to `git_override`, adding `patch_cmds` to `archive_override`, etc., but the better alternative is to just forward all kwargs to the actual underlying repo rule. * This somehow led to a big refactor where I remove the various `NonRegistryOverride` impls in favor of a simple wrapper around a `RepoSpec`, which led to the creation of a `RepoRuleId` class, which led to a refactor in BzlmodRepoRuleFunction (which also now houses the previous logic to validate labels in `ModuleFileGlobals`). * Also includes some random Java 21 fixes that I couldn't resist... (`ModuleOverride` is now a sealed interface; added several switch expressions) RELNOTES: `archive_override` now accepts all attributes usable with `http_archive`; similar for `git_override` and `git_repository`. Fixes #24412 Closes #24378. PiperOrigin-RevId: 698515353 Change-Id: I285c382d10ef228d46a1f1d732daa77a21bf890b
github-actions
bot
added
team-Performance
iancha1992
approved these changes
Nov 21, 2024
github-actions
bot
removed
the
awaiting-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains cherry-picks of:
RELNOTES:
archive_overridenow accepts all attributes usable withhttp_archive; similar forgit_overrideandgit_repository.