Skip to content

Commit

Permalink
Add -XDshould-stop.ifError=FLOW to the default javacopts.
Browse files Browse the repository at this point in the history
See google/error-prone#4595 for motivation. This fixes a bug with the interaction between javac and Error Prone, but also improves diagnostic quality in general by showing more errors if there are multiple problems and multiple files being compiled.

PiperOrigin-RevId: 686100365
Change-Id: I2e5e6dffdbbe1ca6480369a51a7ea3445db78a8a
  • Loading branch information
cushon authored and rules_java Copybara committed Oct 15, 2024
1 parent 9226c76 commit 5fe8347
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions toolchains/default_java_toolchain.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ JDK9_JVM_OPTS = BASE_JDK9_JVM_OPTS
DEFAULT_JAVACOPTS = [
"-XDskipDuplicateBridges=true",
"-XDcompilePolicy=simple",
"-XDshould-stop.ifError=FLOW", # See b/27049950, https://github.com/google/error-prone/issues/4595
"-g",
"-parameters",
# https://github.com/bazelbuild/bazel/issues/15219
Expand Down

0 comments on commit 5fe8347

Please sign in to comment.