-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make bazel lock file cross-platform #2453
Merged
illicitonion
merged 14 commits into
bazelbuild:main
from
cameron-martin:cross-platform-lock-file
Apr 5, 2024
Merged
Make bazel lock file cross-platform #2453
illicitonion
merged 14 commits into
bazelbuild:main
from
cameron-martin:cross-platform-lock-file
Apr 5, 2024
Commits on Feb 1, 2024
-
Make bazel lock file cross-platform
Since the host tools are os and arch specific, previously bazel would cache the resolution of these in the lock file, causing the repo for the wrong OS or arch to be used when moving between machines. Bazel has the `os_dependent` and `arch_dependent` attributes in the module extension to "key" this resolution by OS and arch. However, the `rust` module extension handles fetching of all the other toolchains as well as the host tools, and we don't really want to key these too. Therefore the host tools are moved to their own module extension. This means we can no longer match the host toolchain's version, edition, etc with the toolchain registered via `rust.toolchain` by default, and instead default to a fixed version. This can still be overriden separately in the root module. I think this is okay, because the host tools are only used for bootstrapping and I don't think there's much need to have them match. This is tested by now checking in the MODULE.bazel.lock file of the bzlmod example, and the CI runners that test on multiple platforms will pass. Resolves bazelbuild#2452
Configuration menu - View commit details
-
Copy full SHA for 504e521 - Browse repository at this point
Copy the full SHA 504e521View commit details
Commits on Mar 2, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 0e6fe84 - Browse repository at this point
Copy the full SHA 0e6fe84View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0888c0f - Browse repository at this point
Copy the full SHA 0888c0fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1feb1cd - Browse repository at this point
Copy the full SHA 1feb1cdView commit details
Commits on Mar 12, 2024
-
Configuration menu - View commit details
-
Copy full SHA for acea9b5 - Browse repository at this point
Copy the full SHA acea9b5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 90cbbb1 - Browse repository at this point
Copy the full SHA 90cbbb1View commit details
Commits on Mar 16, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 430e9b4 - Browse repository at this point
Copy the full SHA 430e9b4View commit details
Commits on Mar 28, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 6336779 - Browse repository at this point
Copy the full SHA 6336779View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6c1a1c9 - Browse repository at this point
Copy the full SHA 6c1a1c9View commit details
Commits on Mar 29, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 5111abb - Browse repository at this point
Copy the full SHA 5111abbView commit details
Commits on Apr 1, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 53f9124 - Browse repository at this point
Copy the full SHA 53f9124View commit details -
Configuration menu - View commit details
-
Copy full SHA for 67b5de8 - Browse repository at this point
Copy the full SHA 67b5de8View commit details
Commits on Apr 4, 2024
-
Configuration menu - View commit details
-
Copy full SHA for b1f283f - Browse repository at this point
Copy the full SHA b1f283fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7835de9 - Browse repository at this point
Copy the full SHA 7835de9View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.