Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make bazel lock file cross-platform #2453

Merged
merged 14 commits into from
Apr 5, 2024

Commits on Feb 1, 2024

  1. Make bazel lock file cross-platform

    Since the host tools are os and arch specific, previously bazel would cache the resolution of these in the lock file, causing the repo for the wrong OS or arch to be used when moving between machines.
    
    Bazel has the `os_dependent` and `arch_dependent` attributes in the module extension to "key" this resolution by OS and arch. However, the `rust` module extension handles fetching of all the other toolchains as well as the host tools, and we don't really want to key these too. Therefore the host tools are moved to their own module extension. This means we can no longer match the host toolchain's version, edition, etc with the toolchain registered via `rust.toolchain` by default, and instead default to a fixed version. This can still be overriden separately in the root module. I think this is okay, because the host tools are only used for bootstrapping and I don't think there's much need to have them match.
    
    This is tested by now checking in the MODULE.bazel.lock file of the bzlmod example, and the CI runners that test on multiple platforms will pass.
    
    Resolves bazelbuild#2452
    cameron-martin committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    504e521 View commit details
    Browse the repository at this point in the history

Commits on Mar 2, 2024

  1. Configuration menu
    Copy the full SHA
    0e6fe84 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0888c0f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    1feb1cd View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2024

  1. Configuration menu
    Copy the full SHA
    acea9b5 View commit details
    Browse the repository at this point in the history
  2. Update comment

    cameron-martin committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    90cbbb1 View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2024

  1. Empty commit

    cameron-martin committed Mar 16, 2024
    Configuration menu
    Copy the full SHA
    430e9b4 View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2024

  1. Configuration menu
    Copy the full SHA
    6336779 View commit details
    Browse the repository at this point in the history
  2. Fix buildifier

    cameron-martin committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    6c1a1c9 View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2024

  1. Configuration menu
    Copy the full SHA
    5111abb View commit details
    Browse the repository at this point in the history

Commits on Apr 1, 2024

  1. Update lock file

    cameron-martin committed Apr 1, 2024
    Configuration menu
    Copy the full SHA
    53f9124 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    67b5de8 View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2024

  1. Configuration menu
    Copy the full SHA
    b1f283f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7835de9 View commit details
    Browse the repository at this point in the history