-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moved rust extension rules into a separate workspaces. #3007
Conversation
6820db7
to
dc90468
Compare
08678f2
to
f8a6bf3
Compare
I started down that path and hit the 80 job cap for BazelCI. For each extension I would want to test them on Linux, Linux RBE, MacOS, and Windows, and to have each product be it's own workspace didn't seem possible. Though @meteorcloudy maybe there's a way to raise that cap? edit: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy to do this, equally happy to have a per-extension module if that's practical :) Thanks for doing the work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Looks good (if we manage to solve the testing CI limit situation, splitting this up more would be good too).
The commit I just added splits the extensions into their own repositories but hits the following error: https://buildkite.com/bazel/rules-rust-rustlang/builds/12747#0193646f-6c25-4faa-a809-e5e319a1c9e6
@meteorcloudy @krasimirgg there's no way to raise this is there 😅 (Plus, it would be nice to be told how many were found) |
ed4abd5
to
d2abc05
Compare
I've created bazelbuild/continuous-integration#2120 as a hopeful path forward. |
presubmit is now working https://buildkite.com/bazel/rules-rust-rustlang/builds/12752 |
dc7be3a
to
21ceb8b
Compare
With this in place I'll go ahead and update the PR to reflect the granular workspaces change instead of |
5f993e7
to
d78aaab
Compare
rules_rust_ext
workspace.
This change moves the
bindgen
,proto
, andwasm_bindgen
sub-packages into individual workspaces within theextensions
directory. The intent is improve ease of maintenance of both core and extension Rust rules by ensuring changes to extensions have no impact on the core rules. Core rules should never depend on extensions.Load statements should be updated according to the following table:
@rules_rust//bindgen
@rules_rust_bindgen//
@rules_rust//proto/prost
@rules_rust_prost//
@rules_rust//proto/protobuf
@rules_rust_protobuf//
@rules_rust//wasm_bindgen
@rules_rust_wasm_bindgen//
closes #2882