Broaden the search range #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A user bug report revealed that the algorithm was working poorly in a scenario where the two input files were of very different lengths. This turned out to be a longstanding logic error in te cross-correlation algorithm, which has been addressed in this update.
Numpy v2 has compatibility issues with other dependencies, so we'll skip it for now.
We can no longer assume that the zero offset point is in the centre of the plot.
|
I realised after committing that the plots were broken - now committing some changes to fix that (and fix the tests following the changes to fix the plots). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A user bug report revealed that the algorithm was working poorly in a scenario where the two input files were of very different lengths. This turned out to be a longstanding logic error in the cross-correlation algorithm, which has been addressed in this update.