Remove default trim #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks like I missed some code that was affected by the changes.
Recent bugs have arisen because of the lack of tests that search for a short audio clip withi n a longer file. Adding a longer audio file to the automated tests is an attempt to remedy t his.
Previously the tool defaulted to only comparing the first fifteen minutes of each file. Making this the default is now considered an anti-feature, and it has now been made optional.
This proves that (a) not specifying a trim value works, and (b) changing the amount of audio being compared changes the standard score of the result.
chrisn
approved these changes
Jun 19, 2024
Tweak capitalisation Co-authored-by: Chris Needham <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the tool defaulted to only comparing the first fifteen minutes of each file. Making this the default is now considered an anti-feature, and it has now been made optional.
The README has also been improved to document all the command-line options, and a test has been added to check that comparing files without trimming them works as expected.