Removing hasOwnProperty check and adding jshint ignore:line where tes…

…ts require inherited functions to be stubbed
bbc · Oct 14, 2015 · 3c7a6f5 · 3c7a6f5
1 parent a0708f5
commit 3c7a6f5
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 12 deletions.
diff --git a/static/script-tests/tests/widgets/carousel.js b/static/script-tests/tests/widgets/carousel.js
@@ -55,12 +55,10 @@
         function stubUnstubbedFunctions(Class) {
             var prototype, propertyName, property;
             prototype = Class.prototype;
-            for (propertyName in prototype) {
-                if (prototype.hasOwnProperty(propertyName)) {
-                    property = prototype[propertyName];
-                    if ((typeof property === 'function') && !(property.restore && property.restore.sinon) && propertyName !== 'self') {
-                        self.sandbox.stub(prototype, propertyName);
-                    }
+            for (propertyName in prototype) { //jshint ignore:line
+                property = prototype[propertyName];
+                if ((typeof property === 'function') && !(property.restore && property.restore.sinon) && propertyName !== 'self') {
+                    self.sandbox.stub(prototype, propertyName);
                 }
             }
         }

diff --git a/static/script-tests/tests/widgets/carousel/navigators/testhelpers/navigator.js b/static/script-tests/tests/widgets/carousel/navigators/testhelpers/navigator.js
@@ -39,12 +39,10 @@ require.def('tests/widgets/navigators/testhelpers/navigator',
                 function stubUnstubbedFunctions(Class) {
                     var prototype, propertyName, property;
                     prototype = Class.prototype;
-                    for (propertyName in prototype) {
-                        if (prototype.hasOwnProperty(propertyName)) {
-                            property = prototype[propertyName];
-                            if ((typeof property === 'function') && !(property.restore && property.restore.sinon) && propertyName !== 'self') {
-                                self.sandbox.stub(prototype, propertyName);
-                            }
+                    for (propertyName in prototype) { //jshint ignore:line
+                        property = prototype[propertyName];
+                        if ((typeof property === 'function') && !(property.restore && property.restore.sinon) && propertyName !== 'self') {
+                            self.sandbox.stub(prototype, propertyName);
                         }
                     }
                 }