Allow specification of timeout and number of threads in config file #358
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wraith uses a standard timeout of 1000 ms and 8 threads. This can cause issues when comparing a large number of pages in that contention is so great the whole page is not retrieved before timing out. This leads to differences being reported that aren't really there.
This PR allows the number or threads and the timeout to use to be specified in the config file, as follows:
num_threads: 3
timeout_ms: 3000
It these values are not specified in the config file, the old defaults of 8 and 1000 are used.