Skip to content

Commit

Permalink
When focusing and RaiseOnFocus, release button grab for issue #759.
Browse files Browse the repository at this point in the history
Related to issue #742: Strange Firefox Behavior in IceWM. Icewm retains a button grab after focusing. This is problematic for Firefox and Chrome with hover elements on webpages. Data used by canRaise() and overlapped() functions is only updated after YFrameWindow::setWinFocus() ends. When RaiseOnFocus is true we know that the focused window will eventually be raised and it is unnecessary to retain the button grab. This issue remains for RaiseOnClickClient when RaiseOnFocus is false.
  • Loading branch information
PetteriAimonen authored Dec 24, 2023
1 parent d633b37 commit bde6bb5
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/wmframe.cc
Original file line number Diff line number Diff line change
Expand Up @@ -1967,7 +1967,7 @@ void YFrameWindow::setWinFocus() {
}
updateTaskBar();

if (!raiseOnClickClient || !canRaise() || !overlapped())
if (!raiseOnClickClient || raiseOnFocus || !canRaise() || !overlapped())
container()->releaseButtons();
if (taskBar) {
taskBar->workspacesRepaint(getWorkspace());
Expand Down

0 comments on commit bde6bb5

Please sign in to comment.