Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heads-up: VEP annotations can have a SOMATIC field and this breaks vcf2db parsing #2966

Closed
lbeltrame opened this issue Oct 3, 2019 · 3 comments

Comments

@lbeltrame
Copy link
Contributor

As the topic says, the way vcf2db parses annotations (quinlan-lab/vcf2db#61) can break in case VEP includes a SOMATIC field, because it will overwrite the SOMATIC flag already present when vcf2db parses the file, and will cause a cryptic constraints error when trying to build a database.

@chapmanb
Copy link
Member

chapmanb commented Oct 4, 2019

Luca;
Thanks much for the heads up on the issue. In this case, it seems like VEP should not be overwriting or changing the existing SOMATIC flag. That's pretty widely used across callers. Is it possible to raise an issue with the VEP team and see if they have a workaround for this issue we could apply in bcbio to avoid the problem? Thanks again for looking into this.

@lbeltrame
Copy link
Contributor Author

I see the issue as twofold:

  • VEP has an additional SOMATIC field, but, AFAICS, it is part of the CSQ field in INFO;
  • When vcf2db parses the info, it overwrites the somatic field because geneimpacts misparses the record (as far as I could remember when I investigated the issue)

How can one report bugs to the VEP? Even if it is a problem with vcf2db, the naming clash is unfortunate.

@chapmanb
Copy link
Member

chapmanb commented Oct 4, 2019

Luca -- thanks for the additional details. It sounds from your description like geneimpacts/vcf2db is probably the right place to fix this, rather than VEP since it's putting it into the CSQ field. Apologies, I'd misunderstood. It doesn't seem like there is much we can do on the bcbio side to mitigate the problem but hopefully it'll get fixed from the gemini side soon. Thanks again for digging into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants