Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of S3-specific code #46

Open
forman opened this issue Jun 16, 2021 · 0 comments
Open

Get rid of S3-specific code #46

forman opened this issue Jun 16, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@forman
Copy link
Member

forman commented Jun 16, 2021

We have some S3-specifc code in DataWriter that I'd like to get rid off: less, code less need for testing, higher coverage.

We can avoid S3-specifc code by relying entirely on the fsspec package and auto-configuration through keyword injection from config YAML.

See also xcube-dev/xcube#446
@forman forman added the enhancement New feature or request label Jun 16, 2021
@forman forman changed the title Instead of adding new unit tests, I'd prefer we get rid of any s3-specific code. We can do this by relying entirely on the fsspec package and auto-configuration through keyword injection from config YAML. Get rid of s3-specific code Jun 16, 2021
@forman forman changed the title Get rid of s3-specific code Get rid of S3-specific code Jun 16, 2021
@forman forman mentioned this issue Jun 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@forman